fix(android): prevent export of events with missing data files#3259
Draft
fix(android): prevent export of events with missing data files#3259
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
On certain Xiaomi devices (Android 11, 13), events with missing data files are sent to the server despite pre-export validation. The exact cause is unclear. Additionally, a rare race condition in DataCleanupService deletes event files for batched events when max memory usage is reached. - DataCleanupService now only deletes files for unbatched events - NetworkClient skips events with missing data files during JSON serialization, closer to when the file is actually read - Remove redundant pre-export file validation from Exporter - Remove unused FileStorage.validateFile Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abhaysood
force-pushed
the
skip-events-with-no-data
branch
from
b5495f0 to
609096e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On certain Xiaomi devices (Android 11, 13), events with missing data
files are sent to the server despite pre-export validation. The exact
cause is unclear. Additionally, a rare race condition in
DataCleanupService deletes event files for batched events when max
memory usage is reached.
serialization, closer to when the file is actually read
Related issue
Closes #3030